Console paging#360
Open
seliayeu wants to merge 12 commits into
Open
Conversation
✅ Deploy Preview for lodestone-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for lodestone-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CheatCod
requested changes
Dec 10, 2023
CheatCod
left a comment
CheatCod
left a comment
Member
There was a problem hiding this comment.
When user enters the console page, it should display the latest log, and as the user scrolls up, older logs are fetched
CheatCod
requested changes
Dec 10, 2023
CheatCod
left a comment
CheatCod
left a comment
Member
There was a problem hiding this comment.
Does not seem to be working consistently for me, reproducible in the following step
- start a Minecraft server
- hold down enter key so it generates loads of console logs
- refresh the page, I am put on top of the console log but it's incomplete
Member
|
Add a loading animation to notify the user the page is being fetched |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds pagination for console logs